Skip to content

[slimtensor] Storage and SharedPtr for CPU owning mode #16383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Gasoonjia wants to merge 1 commit into
base: gh/gasoonjia/74/base
Choose a base branch
from
Open

[slimtensor] Storage and SharedPtr for CPU owning mode #16383

Gasoonjia wants to merge 1 commit into from
+754 −0

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Dec 24, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This diff introduces the foundation for tensor storage management in the SlimTensor migration:

  • util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
  • core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
    • DeviceTraits specialization with allocate(), free(), memcpy() using malloc/free
    • Owning mode for CPU device (CUDA and non-owning mode added later)
    • Storage type alias as SharedPtr
    • Move semantics for efficient resource transfer
    • clone() and copy_() methods for data management

Differential Revision: D89747980

@Gasoonjia
[slimtensor] Storage and SharedPtr for CPU owning mode
39d4ccf 
This diff introduces the foundation for tensor storage management in the SlimTensor migration:

- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
    - DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
    - Owning mode for CPU device (CUDA and non-owning mode added later)
    - Storage type alias as SharedPtr<MaybeOwningStorage>
    - Move semantics for efficient resource transfer
    - clone() and copy_() methods for data management

Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16383

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit 39d4ccf with merge base 210047b (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2025
This was referenced Dec 24, 2025
Open
Open
Open
@github-actions
Copy link

github-actions bot commented Dec 24, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gasoonjia